Migrate test off enzyme and karma #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
reviewed
Jul 11, 2024
src/Overlay.tsx
Outdated
| @@ -222,7 +222,9 @@ const Overlay = React.forwardRef<HTMLElement, OverlayProps>( | |||
| onEntered, | |||
| }); | |||
|
|
|||
| return container ? ReactDOM.createPortal(child, container) : null; | |||
| return ( | |||
| <>{container ? ReactDOM.createPortal(<>{child}</>, container) : null}</> | |||
There was a problem hiding this comment.
Was wrapping the portal + children in fragments required?
There was a problem hiding this comment.
just for TS, but should be harmless i think?
There was a problem hiding this comment.
Hmm unsure. I did pull down the branch and reverting the changes compiled for me. Maybe it conflicted with an earlier change?
There was a problem hiding this comment.
you're right, nuking node_modules fixed it
Co-authored-by: Kyle Tsang <6854874+kyletsang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😥 This was more work than i was hoping for. But in a position to actually test out react 19
Switching tests from karma to vitest, and remove all the remaining enzyme