Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure build script, cake script, complying with code standards #241

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

glennawatson
Copy link
Member

  • Add logo, changed the directory.build.props to match.
  • Add editorconfig, this is common settings that multiple editors obey.
  • add cake build scripts, these are standard ones we use on reactiveui
  • add azure build config file, removed appveyor
  • Moved the src files into /src/ directory, this is what our build recipe wants.
  • Made ChangeAwareList thread aware, there was a problem the analyzers picked up where you could async elements not have SynchronisationContext
  • Made most async methods use ConfigureAwait(false), this can be a small optimisation since it doesn't have to worry about returning on the same thread.
  • Add a base level of analyzers, they pick up common code problems.
  • The analyzers picked up methods that weren't covered by null checks added those
  • Passed the param name into ArgumentException's, where there wasn't a parameter to the method changed the exception to IndexOutOfRangeException
  • removed whitespace from end of lines.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c0d4fb1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #241   +/-   ##
=========================================
  Coverage          ?   63.27%           
=========================================
  Files             ?      214           
  Lines             ?    10621           
  Branches          ?     1753           
=========================================
  Hits              ?     6720           
  Misses            ?     3082           
  Partials          ?      819

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d4fb1...1fd8079. Read the comment docs.

Copy link
Collaborator

@RolandPheasant RolandPheasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging #242 first has caused this PR to conflict

@RolandPheasant RolandPheasant merged commit 22ee78b into master Jul 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-logo-stuff branch July 10, 2019 05:43
@lock lock bot locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants