Fix deadlock in transform async #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransform async. This fixes #157 hopefully
glennawatson
approved these changes
Sep 14, 2020
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 62.93% 70.25% +7.31%
==========================================
Files 216 213 -3
Lines 11578 11342 -236
Branches 2142 0 -2142
==========================================
+ Hits 7287 7968 +681
+ Misses 3399 3374 -25
+ Partials 892 0 -892
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes an issue where a deadlock can occur in the transform async operator
What is the current behavior?
See #157
What is the new behavior?
No deadlock hopefully
What might this PR break?
Now ignores parallelisation option. I will come back to this later as I doubt anyone will be effected.,
Please check if the PR fulfills these requirements
Hell yeah
Other information:
None