fix #318 #488
Merged
fix #318 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't know why this test fails, locally it passes |
|
... also the failing test isn't even related to my changes |
|
@RolandPheasant Opinions on this? |
|
Sorry ain't got around to looking yet. Will do so over the weekend. |
| @@ -14,119 +14,119 @@ internal class InnerJoin<TLeft, TLeftKey, TRight, TRightKey, TDestination> | |||
| { | |||
| private readonly IObservable<IChangeSet<TLeft, TLeftKey>> _left; | |||
|
|
|||
| private readonly Func<TLeftKey, TLeft, TRight, TDestination> _resultSelector; | |||
| private readonly Func<(TLeftKey leftKey, TRightKey rightKey), TLeft, TRight, TDestination> _resultSelector; | |||
There was a problem hiding this comment.
This makes perfect sense to me
|
I am happy to merge this but before we release, we need a wiki page to explain the breaking change and why. Are you happy to do that? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InnerJoin implementation similar to #483
This might be an even more breaking change since the key is now a tuple...