Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Predicate #599

Merged
merged 3 commits into from
May 23, 2022
Merged

Connect Predicate #599

merged 3 commits into from
May 23, 2022

Conversation

RolandPheasant
Copy link
Collaborator

Add unit test to illustrate that connect predicate works as expected and has historically been fixed.

Fixes #471

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #599 (06083c3) into main (c3baded) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files         215      215           
  Lines       10718    10718           
=======================================
  Hits         7660     7660           
  Misses       3058     3058           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3baded...06083c3. Read the comment docs.

@RolandPheasant RolandPheasant merged commit 19daee8 into main May 23, 2022
@RolandPheasant RolandPheasant deleted the ConnectPredicate branch May 23, 2022 19:07
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect predicate is filtering out changes and not updating bound lists correctly
2 participants