Feature: MergeMany Support for OnComplete (List Version) #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwcullop
changed the title
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
==========================================
+ Coverage 64.29% 64.36% +0.06%
==========================================
Files 222 222
Lines 11224 11246 +22
Branches 2271 2273 +2
==========================================
+ Hits 7217 7239 +22
Misses 3062 3062
Partials 945 945
|
RolandPheasant
approved these changes
Oct 26, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the List version of
MergeManyto have the same behavior added to the cache version (#736): The resulting sequence will fireOnCompletewhen the source sequence and all child sequences complete. It is the same behavior asObservable.SelectMany.All of the changes are identical to the changes made to the cache version. The
SubscriptionCounterclass could be abstracted out and shared between them, but that doesn't seem to be consistent with how things work in this repo, so I didn't do it that way.This change is needed for the upcoming List version of
MergeManyChangeSets(still in progress) but this part is done, with unit tests, and it makes sense to have it as a separate PR.