ToConcreteType Update

[dwcullop]

Description

This PR continues to effort to replace IChangeSet<TObject, TKey> with ChangeSet<TObject, TKey> in order to avoid allocations that can take place when enumerating with the former instead of the latter.

• Updates ToConcreteType to throw an exception if a non-ChangeSet implementation of IChangeSet is encountered
• Changes anywhere enumeration would happen using IChangeSet to invoke ToConcreteType so that it is done with ChangeSet instead.
• When possible, IChangeSet was completely replaced with ChangeSet in order to ensure more consistent use and reduce the number of places that ToConcreteType needs to be invoked explicitly

[codecov]

Codecov Report

Merging #751 (de49b48) into main (269828b) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   64.74%   64.74%           
=======================================
  Files         226      226           
  Lines       11464    11459    -5     
  Branches     2335     2334    -1     
=======================================
- Hits         7422     7419    -3     
+ Misses       3085     3083    -2     
  Partials      957      957           

Files	Coverage Δ
src/DynamicData/Aggregation/AggregateEnumerator.cs	67.64% <100.00%> (ø)
src/DynamicData/Binding/BindingListAdaptor.cs	76.19% <100.00%> (ø)
...DynamicData/Binding/ObservableCollectionAdaptor.cs	83.72% <100.00%> (+4.55%)	⬆️
src/DynamicData/Cache/Internal/AbstractFilter.cs	53.33% <100.00%> (ø)
src/DynamicData/Cache/Internal/Cache.cs	69.69% <100.00%> (ø)
src/DynamicData/Cache/Internal/Combiner.cs	89.65% <100.00%> (ø)
src/DynamicData/Cache/Internal/DisposeMany.cs	95.12% <100.00%> (ø)
src/DynamicData/Cache/Internal/IndexCalculator.cs	81.17% <100.00%> (ø)
.../DynamicData/Cache/Internal/RemoveKeyEnumerator.cs	72.72% <100.00%> (ø)
src/DynamicData/Cache/Internal/TransformMany.cs	95.27% <100.00%> (ø)
... and 4 more

[RolandPheasant]

Thanks.

[RolandPheasant]

I think this should be changed to the traditional foreach() loop instead of the ForEach extension.

I wrote the ForEach extension, but it was misguided as it also allocates. However, looking at the usages:

That should be changed in a distinct PR

[dwcullop]

Yeah, I can do a distinct PR for that. I'd like to understand more about why it allocates because that is news to me. As a fan of ForEach, maybe it can be updated to avoid the allocation instead of needing to be removed.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.