Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Add Net 8.0, update code to c#12, Fix decimal StdDev #756

Merged
merged 15 commits into from
Nov 16, 2023

Conversation

ChrisPulman
Copy link
Member

Fix coding standard misalignments
Update build scripts

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 382 lines in your changes are missing coverage. Please review.

Comparison is base (53d5f6d) 64.74% compared to head (cc8ffe0) 65.01%.

❗ Current head cc8ffe0 differs from pull request most recent head daadd59. Consider uploading reports for the commit daadd59 to get more accurate results

Files Patch % Lines
src/DynamicData/Cache/ObservableCacheEx.cs 52.38% 19 Missing and 1 partial ⚠️
src/DynamicData/List/ObservableListEx.cs 67.56% 12 Missing ⚠️
src/DynamicData/Aggregation/AvgEx.cs 73.68% 10 Missing ⚠️
src/DynamicData/Aggregation/SumEx.cs 74.35% 10 Missing ⚠️
src/DynamicData/Aggregation/StdDevEx.cs 76.66% 5 Missing and 2 partials ⚠️
src/DynamicData/List/Internal/GroupOnProperty.cs 0.00% 7 Missing ⚠️
src/DynamicData/Aggregation/CountEx.cs 25.00% 6 Missing ⚠️
src/DynamicData/Cache/Internal/CacheUpdater.cs 53.84% 6 Missing ⚠️
src/DynamicData/Cache/Internal/GroupOnImmutable.cs 72.72% 4 Missing and 2 partials ⚠️
...icData/Cache/Internal/TransformWithInlineUpdate.cs 53.84% 4 Missing and 2 partials ⚠️
... and 123 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   64.74%   65.01%   +0.27%     
==========================================
  Files         226      226              
  Lines       11459    11045     -414     
  Branches     2334     2304      -30     
==========================================
- Hits         7419     7181     -238     
+ Misses       3083     2916     -167     
+ Partials      957      948       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman changed the title Feature : Add Net 8.0, update code to c#11 Feature : Add Net 8.0, update code to c#12 Nov 14, 2023
@ChrisPulman ChrisPulman marked this pull request as draft November 14, 2023 23:48
@glennawatson
Copy link
Member

Less code meaning more impact on the code coverage. Chris is adding more tests to bring the project level back up.

@ChrisPulman ChrisPulman marked this pull request as ready for review November 15, 2023 21:34
@ChrisPulman ChrisPulman changed the title Feature : Add Net 8.0, update code to c#12 Feature : Add Net 8.0, update code to c#12, Fix decimal StdDev Nov 15, 2023
@glennawatson glennawatson marked this pull request as draft November 16, 2023 00:47
@glennawatson
Copy link
Member

Going to add API surface tests before merging. That way we can see if any API surface has changed.

@ChrisPulman ChrisPulman marked this pull request as ready for review November 16, 2023 17:36
@ChrisPulman ChrisPulman enabled auto-merge (squash) November 16, 2023 17:38
@ChrisPulman ChrisPulman merged commit 85cd7a7 into main Nov 16, 2023
1 check passed
@ChrisPulman ChrisPulman deleted the CP_AddNet8_0Target branch November 16, 2023 17:42
@@ -12,10 +13,10 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="xunit" Version="2.6.1" />
<PackageReference Include="xunit.runner.console" Version="2.6.1" />
<PackageReference Include="xunit" Version="$(XunitVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how dependabot will like this one.

Copy link

github-actions bot commented Dec 1, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants