Cleanup fix for .DisposeMany()
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teardown of the stream, I.E. unsubscription.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
+ Coverage 64.74% 65.65% +0.91%
==========================================
Files 226 227 +1
Lines 11459 11117 -342
Branches 2334 2294 -40
==========================================
- Hits 7419 7299 -120
+ Misses 3083 2882 -201
+ Partials 957 936 -21 ☔ View full report in Codecov by Sentry. |
RolandPheasant
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Hopefully this will do the job. @dwcullop can confirm by updating his PR to the latest branch after this is merged.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed that
.DisposeMany()was not disposing items after downstream-teardown of the stream, I.E. unsubscription.I was mistaken that
onCompletedpropagates to upstream observers. The mechanism for detecting downstream completion is theIDisposablethat each subscription returns.