Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #671 #774

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix for #671 #774

merged 1 commit into from
Dec 5, 2023

Conversation

JakenVeina
Copy link
Collaborator

Fixed that non-observable objects within a property expression used by .WhenPropertyChanged() were incorrectly simulating notifications of property changes, immediately upon subscription, resulting in infinite looping, as a side-effect of the implementation for capturing object changes by re-subscribing to the inner change stream upon any changes in the expression.

Fixes #671.

@JakenVeina JakenVeina force-pushed the issue-671 branch 2 times, most recently from b1ffad7 to e7b6a84 Compare December 5, 2023 03:30
…y `.WhenPropertyChanged()` were incorrectly simulating notifications of property changes, immediately upon subscription, resulting in infinite looping, as a side-effect of the implementation for capturing object changes by re-subscribing to the inner change stream upon any changes in the expression.

Fixes #671.
@JakenVeina JakenVeina merged commit bb8b5dc into main Dec 5, 2023
1 check passed
@JakenVeina JakenVeina deleted the issue-671 branch December 5, 2023 03:39
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: WhenPropertyChanged trapped in endless loop
3 participants