Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some index -1 exceptions #781

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Conversation

RolandPheasant
Copy link
Collaborator

  1. Prevent index -1 exception when connecting to source list. Fixes [Bug]: AddRange ChangeSet has unexpected Index of -1 #723
  2. Prevent further index=-1 exceptions when converting an observable collection (including AvaloniaDictionary). Fixes [Bug]: System.ArgumentException: index cannot be greater than the size of the collection #683 and fixes [Bug]: System.ArgumentException: index cannot be negative #710

…mark something with [Serializable] when that was a bad idea in 2004 and is totally evil in 2023. Binary formatting support required?? Please grow up and remove this as a suggestion to spare people the problem of having to turn it off.
@RolandPheasant
Copy link
Collaborator Author

@JakenVeina

I will say you should add a comment here, mentioning that this is copied directly form Avalonia, and why.

I actually thought that but didn't bother. You're right. Comment added and pushed.

@RolandPheasant
Copy link
Collaborator Author

@JakenVeina

UnspecifiedIndexException?

Ouch, Good call. I'd forgotten this was even a thing, It's been so many years. I'll consolidate

@JakenVeina
Copy link
Collaborator

@RolandPheasant

Ouch, Good call. I'd forgotten this was even a thing, It's been so many years. I'll consolidate

Yeah, that's definitely what I was referring to. Not just attempting to suggest a different name that I didn't think already existed.

@RolandPheasant RolandPheasant merged commit df66dd4 into main Dec 5, 2023
1 check passed
@RolandPheasant RolandPheasant deleted the feature/minus-one-issues branch December 5, 2023 10:44
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants