Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #925 #926

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix for #925 #926

merged 1 commit into from
Aug 16, 2024

Conversation

JakenVeina
Copy link
Collaborator

@JakenVeina JakenVeina commented Aug 16, 2024

Fixed a bogus use of the default keyword, within a ternary expression where implicit casting of a generic is in play. The expression compiles differently depending on whether the generic type in question is a value type, versus a reference type, and generates an exception in the case of a value type.

…on where implicit casting of a generic is in play. The expression compiles differently depending on whether the generic type in question is a value type, versus a reference type, and generates an excpetion in the case of a value type.
@JakenVeina JakenVeina self-assigned this Aug 16, 2024
Copy link
Member

@dwcullop dwcullop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this so quickly.

@JakenVeina JakenVeina merged commit afbbb47 into main Aug 16, 2024
1 check passed
@JakenVeina JakenVeina deleted the bug/transform-immutable-add-with-previous branch August 16, 2024 19:56
erri120 added a commit to erri120/NexusMods.App that referenced this pull request Aug 28, 2024
erri120 added a commit to erri120/NexusMods.App that referenced this pull request Aug 29, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TransformImmutable: For ChangeReason.Add, a previous value cannot be specified
2 participants