Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] stale link in react-modal/docs/styles/classes.md #834

Merged
merged 1 commit into from
Nov 2, 2020
Merged

[fixed] stale link in react-modal/docs/styles/classes.md #834

merged 1 commit into from
Nov 2, 2020

Conversation

hamirmahal
Copy link
Contributor

All this does is change the "default content styles" hyperlink to index.md instead of README.md, since I think the link to README.md is stale since at least Dec 9, 2019 with commit e5fe406.

Fixes #833.

Changes proposed:

  • Update "default content styles" hyperlink in classes.md to link to index.md instead of README.md

Upgrade Path (for changed or removed APIs):
I don't think this is applicable for this pull request.

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

All this does is change the "default content styles" hyperlink to show `index.md` instead of `README.md`, since I think the link to `README.md` is stale since at least [Dec 9, 2019](https://github.com/reactjs/react-modal/tree/e5fe406111f97269b8a552e9fc5ee285e05941fa/docs/styles) with commit e5fe406.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.632% when pulling cd3e585 on hamirmahal:patch-2 into b2e58e7 on reactjs:master.

@diasbruno diasbruno merged commit 694d425 into reactjs:master Nov 2, 2020
@diasbruno
Copy link
Collaborator

Thanks, @hamirmahal!! 👍

@hamirmahal
Copy link
Contributor Author

hamirmahal commented Nov 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in documentation: http://reactcommunity.org/react-modal/styles/classes/ has a link to a '404' page
3 participants