Naive attempt to implement keepalive connections #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someniatko
commented
May 8, 2018
src/KeepaliveConnector.php
Outdated
|
|
||
| private function tryReuseAliveConnection($uri) | ||
| { | ||
| return $this->aliveConnections[$uri]; |
There was a problem hiding this comment.
there was a check for ConnectionInterface#isWritable() but then i realized $this->aliveConnections is actually an array of Promises.
WyriHaximus
changed the title
WyriHaximus
changed the title
|
Again thanks for bringing this up! I have to close this one as per #152 now that future development will focus on https://github.com/reactphp/http instead. If you feel this makes sense to port over, please file a new PR over in the new repo and I'm happy to help review this 👍 I've migrated the feature request to reactphp/http#39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request is not meant to be merged straight away, but to be reviewed and to get advices how to move forward