Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated alternative Browser constructor argument order #529

Merged
merged 1 commit into from
May 24, 2024

Conversation

clue
Copy link
Member

@clue clue commented May 24, 2024

This simple changeset drops the deprecated alternative Browser constructor argument order. As of v1.5.0, we recommend using the new Browser signature with the optional $connector as first argument and optional $loop as second argument, so upgrading should be straightforward for most use cases:

// unchanged
$browser = new React\Http\Browser();

// old (no longer supported)
$browser = new React\Http\Browser(null, $connector);
$browser = new React\Http\Browser($loop, $connector);

// new (already supported since v1.5.0)
$browser = new React\Http\Browser($connector);
$browser = new React\Http\Browser($connector, $loop);

The original deprecation message has been in place for a couple of years already, so this should be relatively safe to apply.

Note that this temporarily introduces an implicitly nullable type that should be removed in a follow-up as discussed in reactphp/promise#260. Additionally, a follow-up PR should drop the entire $loop argument as discussed in #517.

Builds on top of #418, #528 and reactphp/socket#315.

@clue clue added the BC break label May 24, 2024
@clue clue added this to the v3.0.0 milestone May 24, 2024
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me 👍

@WyriHaximus WyriHaximus merged commit da8ee09 into reactphp:3.x May 24, 2024
14 checks passed
@clue clue deleted the drop-browser-alternative branch May 24, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants