Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnit 10] Fix typo assertObjectHasNotProperty -> assertObjectNotHasProperty #340

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 22, 2024

Ref #338 (review)

Before

There was 1 error:

1) CodeIgniter\Config\BaseConfigTest::testEnvironmentOverrides
Error: Call to undefined method CodeIgniter\Config\BaseConfigTest::assertObjectHasNotProperty()

/Users/samsonasik/www/CodeIgniter4/tests/system/Config/BaseConfigTest.php:134

After

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/phpunit tests/system/Config/BaseConfigTest.php
PHPUnit 10.5.24 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.4 with PCOV 1.0.11
Configuration: /Users/samsonasik/www/CodeIgniter4/phpunit.xml.dist

..................                                           18 / 18 (100%)

Time: 00:00.317, Memory: 14.00 MB

OK (18 tests, 48 assertions)

Generating code coverage report in Clover XML format ... done [00:00.188]

Generating code coverage report in HTML format ... done [00:00.755]

Ref https://github.com/sebastianbergmann/phpunit/blob/bb24b2746512bc8be5122bb220064df8f8687451/src/Framework/Assert.php#L1052C34-L1052C60

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit eff5d58 into main Jun 22, 2024
5 checks passed
@samsonasik samsonasik deleted the fix-typo-assert branch June 22, 2024 19:05
@TomasVotruba
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants