Fixes after PR review

rectorphp · May 25, 2024 · 39259ae · 39259ae
1 parent 06331e4
commit 39259ae
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Config/Level/CodeQualityLevel.php b/src/Config/Level/CodeQualityLevel.php
@@ -112,7 +112,6 @@ final class CodeQualityLevel
         SimplifyFuncGetArgsCountRector::class,
         SimplifyInArrayValuesRector::class,
         SimplifyStrposLowerRector::class,
-        GetClassToInstanceOfRector::class,
         SimplifyArraySearchRector::class,
         SimplifyConditionsRector::class,
         SimplifyIfNotNullReturnRector::class,
@@ -181,8 +180,12 @@ final class CodeQualityLevel
         CompleteMissingIfElseBracketRector::class,
         RemoveUselessIsObjectCheckRector::class,
         StaticToSelfStaticMethodCallOnFinalClassRector::class,
+        GetClassToInstanceOfRector::class,
     ];
 
+    /**
+     * @var array<class-string, mixed[]>
+     */
     public const RULES_WITH_CONFIGURATION = [
         RenameFunctionRector::class => [
             'split' => 'explode',

diff --git a/utils/Finder/SetRectorClassesResolver.php b/utils/Finder/SetRectorClassesResolver.php
@@ -26,15 +26,17 @@ final class SetRectorClassesResolver
     public static function resolve(string $setFile): array
     {
         // special level cases
-        if (realpath($setFile) === realpath(SetList::DEAD_CODE)) {
+        $setFileRealPath = realpath($setFile);
+
+        if ($setFileRealPath === realpath(SetList::DEAD_CODE)) {
             return DeadCodeLevel::RULES;
         }
 
-        if (realpath($setFile) === realpath(SetList::TYPE_DECLARATION)) {
+        if ($setFileRealPath === realpath(SetList::TYPE_DECLARATION)) {
             return TypeDeclarationLevel::RULES;
         }
 
-        if (realpath($setFile) === realpath(SetList::CODE_QUALITY)) {
+        if ($setFileRealPath === realpath(SetList::CODE_QUALITY)) {
             return CodeQualityLevel::RULES;
         }