[Php74] Add HebrevcToNl2brHebrevRector (#5977)

* [Php74] Add HebrevcToNl2brHebrevRector

* regenerate doc

* [ci-review] Rector Rectify

* fix constt

* Fix @see test

---------

Co-authored-by: GitHub Action <actions@github.com>

build/target-repository/docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# 381 Rules Overview
+# 382 Rules Overview
 
 <br>
 
@@ -38,7 +38,7 @@
 
 - [Php73](#php73) (9)
 
-- [Php74](#php74) (13)
+- [Php74](#php74) (14)
 
 - [Php80](#php80) (16)
 
@@ -4730,6 +4730,19 @@ Change `filter_var()` with slash escaping to `addslashes()`
 
 <br>
 
+### HebrevcToNl2brHebrevRector
+
+Change hebrevc($str) to nl2br(hebrev($str))
+
+- class: [`Rector\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector`](../rules/Php74/Rector/FuncCall/HebrevcToNl2brHebrevRector.php)
+
+```diff
+-hebrevc($str);
++nl2br(hebrev($str));
+```
+
+<br>
+
 ### MbStrrposEncodingArgumentPositionRector
 
 Change `mb_strrpos()` encoding argument position

config/set/php74.php

@@ -9,6 +9,7 @@
 use Rector\Php74\Rector\Double\RealToFloatTypeCastRector;
 use Rector\Php74\Rector\FuncCall\ArrayKeyExistsOnPropertyRector;
 use Rector\Php74\Rector\FuncCall\FilterVarToAddSlashesRector;
+use Rector\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector;
 use Rector\Php74\Rector\FuncCall\MbStrrposEncodingArgumentPositionRector;
 use Rector\Php74\Rector\FuncCall\MoneyFormatToNumberFormatRector;
 use Rector\Php74\Rector\FuncCall\RestoreIncludePathToIniRestoreRector;
@@ -23,7 +24,6 @@
             #the_real_type
             # https://wiki.php.net/rfc/deprecations_php_7_4
             'is_real' => 'is_float',
-            //'hebrevc' => ['nl2br', 'hebrev'],
         ]);
 
     $rectorConfig->rules([
@@ -39,5 +39,6 @@
         MoneyFormatToNumberFormatRector::class,
         ParenthesizeNestedTernaryRector::class,
         RestoreIncludePathToIniRestoreRector::class,
+        HebrevcToNl2brHebrevRector::class,
     ]);
 };

rules-tests/Php74/Rector/FuncCall/HebrevcToNl2brHebrevRector/Fixture/fixture.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector\Fixture;
+
+class Fixture
+{
+    public function run($str)
+    {
+        hebrevc($str);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector\Fixture;
+
+class Fixture
+{
+    public function run($str)
+    {
+        nl2br(hebrev($str));
+    }
+}
+
+?>

rules-tests/Php74/Rector/FuncCall/HebrevcToNl2brHebrevRector/Fixture/skip_first_class_callable.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector\Fixture;
+
+final class SkipFirstClassCallable
+{
+    public function run()
+    {
+        return hebrevc(...);
+    }
+}
+
+?>

rules-tests/Php74/Rector/FuncCall/HebrevcToNl2brHebrevRector/Fixture/skip_other_func_call.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector\Fixture;
+
+final class SkipOtherFuncCall
+{
+    public function run($value)
+    {
+        return strlen($value);
+    }
+}
+
+?>

rules-tests/Php74/Rector/FuncCall/HebrevcToNl2brHebrevRector/HebrevcToNl2brHebrevRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class HebrevcToNl2brHebrevRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Php74/Rector/FuncCall/HebrevcToNl2brHebrevRector/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector;
+
+return RectorConfig::configure()
+    ->withRules([HebrevcToNl2brHebrevRector::class]);

rules/Php74/Rector/FuncCall/HebrevcToNl2brHebrevRector.php

@@ -0,0 +1,75 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php74\Rector\FuncCall;
+
+use PhpParser\Node;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Name;
+use Rector\Rector\AbstractRector;
+use Rector\ValueObject\PhpVersionFeature;
+use Rector\VersionBonding\Contract\MinPhpVersionInterface;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @changelog https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.hebrevc
+ * @see \Rector\Tests\Php74\Rector\FuncCall\HebrevcToNl2brHebrevRector\HebrevcToNl2brHebrevRectorTest
+ */
+final class HebrevcToNl2brHebrevRector extends AbstractRector implements MinPhpVersionInterface
+{
+    public function provideMinPhpVersion(): int
+    {
+        return PhpVersionFeature::DEPRECATE_HEBREVC;
+    }
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Change hebrevc($str) to nl2br(hebrev($str))',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+hebrevc($str);
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+nl2br(hebrev($str));
+CODE_SAMPLE
+                ),
+            ]
+        );
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [FuncCall::class];
+    }
+
+    /**
+     * @param FuncCall $node
+     */
+    public function refactor(Node $node): ?FuncCall
+    {
+        if (! $this->isName($node, 'hebrevc')) {
+            return null;
+        }
+
+        if ($node->isFirstClassCallable()) {
+            return null;
+        }
+
+        $node->name = new Name('hebrev');
+        return new FuncCall(
+            new Name('nl2br'),
+            [
+                new Arg($node)
+            ]
+        );
+    }
+}

src/ValueObject/PhpVersionFeature.php

@@ -419,6 +419,11 @@ final class PhpVersionFeature
      */
     public const DEPRECATE_RESTORE_INCLUDE_PATH = PhpVersion::PHP_74;
 
+    /**
+     * @var int
+     */
+    public const DEPRECATE_HEBREVC = PhpVersion::PHP_74;
+
     /**
      * @var int
      */