[TypeDeclaration] Do not remove docblock with description on MergeDat…

…eTimePropertyTypeDeclarationRector (#5931) * [TypeDeclaration] Do not remove docblock with description on MergeDateTimePropertyTypeDeclarationRector * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
rectorphp · May 30, 2024 · a3ed07f · a3ed07f
1 parent b2d1c9d
commit a3ed07f
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/...eDateTimePropertyTypeDeclarationRector/Fixture/do_not_remove_doc_with_description.php.inc b/...eDateTimePropertyTypeDeclarationRector/Fixture/do_not_remove_doc_with_description.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Class_\MergeDateTimePropertyTypeDeclarationRector\Fixture;
+
+final class DoNotRemoveDocWithDescription
+{
+    /**
+     * @var \DateTimeInterface some desc
+     */
+    private \DateTime $dateTime;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Class_\MergeDateTimePropertyTypeDeclarationRector\Fixture;
+
+final class DoNotRemoveDocWithDescription
+{
+    /**
+     * @var \DateTimeInterface some desc
+     */
+    private \DateTimeInterface $dateTime;
+}
+
+?>
diff --git a/rules/TypeDeclaration/Rector/Class_/MergeDateTimePropertyTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/Class_/MergeDateTimePropertyTypeDeclarationRector.php
@@ -99,8 +99,11 @@ public function refactor(Node $node): ?Node
                 ? $this->nodeTypeResolver->getFullyQualifiedClassName($varType)
                 : null;
             if ($className === 'DateTimeInterface') {
-                $phpDocInfo->removeByType(VarTagValueNode::class);
-                $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($property);
+                $varTagvalueNode = $phpDocInfo->getVarTagValueNode();
+                if ($varTagvalueNode instanceof VarTagValueNode && $varTagvalueNode->description === '') {
+                    $phpDocInfo->removeByType(VarTagValueNode::class);
+                    $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($property);
+                }
 
                 $property->type = new FullyQualified('DateTimeInterface');
                 $hasChanged = true;