[ci-review] Rector Rectify

rectorphp · Jul 3, 2024 · df6c206 · df6c206
1 parent 874fdbc
commit df6c206
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictReturnsRector.php b/rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictReturnsRector.php
@@ -4,6 +4,7 @@
 
 namespace Rector\TypeDeclaration\Rector\ClassMethod;
 
+use PhpParser\Node\Expr\UnaryMinus;
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Identifier;
@@ -152,7 +153,7 @@ private function isAlwaysNumeric(array $returns): bool
 
         foreach ($returns as $return) {
             $epxr = $return->expr;
-            if ($epxr instanceof Expr\UnaryMinus) {
+            if ($epxr instanceof UnaryMinus) {
                 $epxr = $epxr->expr;
             }
 

diff --git a/rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictScalarReturnsRector.php b/rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictScalarReturnsRector.php
@@ -4,6 +4,7 @@
 
 namespace Rector\TypeDeclaration\Rector\ClassMethod;
 
+use PhpParser\Node\Expr\UnaryMinus;
 use PhpParser\Node;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Scalar\DNumber;
@@ -85,7 +86,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
 
         foreach ($returns as $return) {
             $expr = $return->expr;
-            if ($expr instanceof Node\Expr\UnaryMinus) {
+            if ($expr instanceof UnaryMinus) {
                 $expr = $expr->expr;
             }
 

diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector.php
@@ -28,11 +28,6 @@ final class ReturnTypeFromStrictScalarReturnExprRector extends AbstractScopeAwar
      */
     public const HARD_CODED_ONLY = 'hard_coded_only';
 
-    /**
-     * @api
-     */
-    private bool $hardCodedOnly = false;
-
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition('Change return type based on strict scalar returns - string, int, float or bool', [
@@ -108,7 +103,5 @@ public function configure(array $configuration): void
     {
         $hardCodedOnly = $configuration[self::HARD_CODED_ONLY] ?? false;
         Assert::boolean($hardCodedOnly);
-
-        $this->hardCodedOnly = $hardCodedOnly;
     }
 }