Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DowngradePhp74] Skip DowngradeCovariantReturnTypeRector on child return parent #1080

Closed

Conversation

samsonasik
Copy link
Member

@TomasVotruba this is the failing test case that probably related with removed return parent, the test case is different use case, while it currently the failing test case return:

from

    public function run(): parent
    {

to:

+    /**
+     * @return parent
+     */
+    public function run(): \Rector\Tests\DowngradePhp74\Rector\ClassMethod\DowngradeCovariantReturnTypeRector\Fixture\AParent

which while different probably different usecase, it should be skipped.

@samsonasik samsonasik force-pushed the skip-downgrade-covariant-return-type-return-parent branch from 62837fb to aa85688 Compare October 27, 2021 09:38
@samsonasik samsonasik closed this Oct 27, 2021
@samsonasik samsonasik deleted the skip-downgrade-covariant-return-type-return-parent branch October 27, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant