[TypeDeclaration] Handle double declare(strict_types=1) addition on DeclareStrictTypesRector + IncreaseDeclareStrictTypesRector

[samsonasik]

While user should choose one of the rules, when it added both, it cause double addition:

 <?php

+declare(strict_types=1);
+
+declare(strict_types=1);
+

which should only one, ref #5926

[samsonasik]

Fixed 🎉

[TomasVotruba]

These 2 rules should never be run together, as they approach same issue differently.
Instead we should raise an error and warn about this, like ECS does for conflicting rules.

[samsonasik]

Ok, when using $nodes, the skipping is working ok, but Name is not yet transformed into FullyQualified

[samsonasik]

I am looking for general issue on rector transformation, while both rules should not run together, but the order of stmt should be kept, so it should already skip already.

[samsonasik]

I got it, the current patch is by check current nodes as well, as ->getNewStmts() seems may overlapped with the $nodes passed.

This handle "just added nodes", which the rule maybe different with both, as the ->getNewStmts() is regenerated after all rules applied, see

rector-src/src/Application/FileProcessor.php

Lines 73 to 74 in e03da04

	// this is needed for new tokens added in "afterTraverse()"
	$file->changeNewStmts($postNewStmts);

[samsonasik]

The another solution is ensure call:

        // ensure update new stmts on each rules applied
        $this->file->changeNewStmts($nodes);

on AbstractRector::beforeTraverse() itself, so file->getNewStmts() is always updated on each rule that just passed.

This will works on general transformation, not only this kind of conflict usage.

[samsonasik]

Ok, using $nodes seems working fine, refactored with check on $nodes 6bc8e02

It seems we should not use $file->getNewStmts() on rules when possible, as $file->changeNewStmts() only called after Rector rules and Post Rector executed

rector-src/src/Application/FileProcessor.php

Lines 73 to 74 in e03da04

	// this is needed for new tokens added in "afterTraverse()"
	$file->changeNewStmts($postNewStmts);

@TomasVotruba I am going to merge it as it may related with how this rule behaviour cross with other rule that change first level stmts ;)