[CodeQuality] Add support for (), {}, [], <> delimiter on RegexPatternDetector #5957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now, as cause error on SimplifyRegexPatternRector |
samsonasik
force-pushed
the
delimiter-other
branch
from
655eeb8
to
4136ed5
Compare
|
Re-open, direct square bracket handled with equal check 4136ed5 |
samsonasik
force-pushed
the
delimiter-other
branch
from
b2bb531
to
a5e7b84
Compare
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
@TomasVotruba I am merging it ;) |
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.