Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodingStyle][Php80] Add join func call support on ConsistentImplodeRector #5958

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[CodingStyle][Php80] Add join func call support on ConsistentImplodeRector #5958

merged 1 commit into from
Jun 10, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 10, 2024 •
edited
Loading

Fixes rectorphp/rector#8662

join is alias of implode

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @amfleurke

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 62fae6a into main Jun 10, 2024
39 checks passed
@samsonasik samsonasik deleted the join-sup branch June 10, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'join' alias is not processed by ConsistentImplodeRector.php
1 participant
@samsonasik