Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php81] Handle usage as arg by ref key on falsy ObjectType on ReadOnlyPropertyRector #6054

Merged
merged 3 commits into from
Jun 27, 2024
Merged

[Php81] Handle usage as arg by ref key on falsy ObjectType on ReadOnlyPropertyRector #6054

merged 3 commits into from
Jun 27, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @nikolicaleksa

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit fa93e65 into main Jun 27, 2024
33 checks passed
@TomasVotruba TomasVotruba deleted the skip-pdo-bindparams branch June 27, 2024 06:36
@TomasVotruba
Copy link
Member

Looks good, thanks 👍

@nikolicaleksa
Copy link
Contributor

Fixed 🎉 /cc @nikolicaleksa

Awesome, thanks for the fast fix!

@samsonasik samsonasik mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadOnlyPropertyRector not detecting when property passed by reference
4 participants
@samsonasik @TomasVotruba @nikolicaleksa @actions-user