[TypeDeclaration] Add ReturnTypeFromMockObjectRector #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-return-mock-object
branch
2 times, most recently
from
63b4b0e
to
48c3f4f
Compare
TomasVotruba
force-pushed
the
tv-return-mock-object
branch
from
48c3f4f
to
a18567a
Compare
samsonasik
reviewed
Jul 21, 2024
rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromMockObjectRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Jul 21, 2024
| return false; | ||
| } | ||
|
|
||
| return in_array(MockObject::class, $type->getObjectClassNames()); |
There was a problem hiding this comment.
use string constant to avoid prefixed on downgrade
Suggested change
| return in_array(MockObject::class, $type->getObjectClassNames()); | |
| return in_array(self::MOCK_OBJECT_CLASS, $type->getObjectClassNames()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easy-pick rule that addes known
MockObjecttypes in tests. It's run early, as removedmixedand intersection types in PHPUnit tests