Skip symfony response in ReturnTypeFromReturnNewRector #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Jul 30, 2024
| @@ -183,6 +184,12 @@ private function refactorDirectReturnNew( | |||
|
|
|||
| $returnType = $this->typeFactory->createMixedPassedOrUnionType($newTypes); | |||
|
|
|||
| // skip in case of response, as handled by another rule earlier | |||
| /** @see ResponseReturnTypeControllerActionRector */ | |||
| if ($returnType instanceof ObjectType && $returnType->isInstanceOf(ResponseClass::BASIC)->yes()) { | |||
There was a problem hiding this comment.
The ResponseReturnTypeControllerActionRector only works on inside controller, if not, eg: a factory class, this seems still should be executed
There was a problem hiding this comment.
Indeed. I'll add the check
There was a problem hiding this comment.
There you go :)
#6204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony Response is already handled exclusively by ResponseReturnTypeControllerActionRector,
to keep each rule more robuts and separated 👍
Also easier to review and add type coverage in a project ugprade :)