Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Skip mixed in union on ClosureReturnTypeRector #6228

Merged
merged 7 commits into from
Aug 12, 2024
Merged

[TypeDeclaration] Skip mixed in union on ClosureReturnTypeRector #6228

merged 7 commits into from
Aug 12, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

I moved the check to use TypeKind::UNION in per associated mapper

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 5126150 into main Aug 12, 2024
35 checks passed
@samsonasik samsonasik deleted the skip-mixed-in-union branch August 12, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @actions-user