always make paths absolute before processing files #6293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kanti
force-pushed
the
always-absolute-path
branch
from
a120a85
to
e4c8621
Compare
Kanti
force-pushed
the
always-absolute-path
branch
2 times, most recently
from
4a95676
to
f8987f2
Compare
samsonasik
reviewed
Sep 6, 2024
Kanti
force-pushed
the
always-absolute-path
branch
from
f8987f2
to
5e1de87
Compare
samsonasik
reviewed
Sep 6, 2024
samsonasik
reviewed
Sep 8, 2024
samsonasik
reviewed
Sep 8, 2024
samsonasik
reviewed
Sep 8, 2024
|
Thank you @Kanti |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path is currently only an absolute path if you call rector with a directory like this
rector process pathToFile/.If you call it with a filename instead, the path will be relative.
rector process pathToFile/File.php.This makes implementing RectorRules with path usage more difficult than necessary.
fixes: sabbelasichon/typo3-rector#4301