[BUGFIX] Ignore phpstan error

rectorphp · Apr 10, 2021 · b4b9ed4 · b4b9ed4
1 parent d5897a7
commit b4b9ed4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/packages-tests/ChangesReporting/ValueObject/RectorWithFileAndLineChangeTest.php b/packages-tests/ChangesReporting/ValueObject/RectorWithFileAndLineChangeTest.php
@@ -17,7 +17,7 @@ public function testGetRectorClassWithChangelogUrl(): void
             1
         );
         $this->assertSame(
-            'Rector\Tests\ChangesReporting\ValueObject\Source\RectorWithLink (https://github.com/rectorphp/rector/blob/master/docs/rector_rules_overview.md)',
+            '"Rector\Tests\ChangesReporting\ValueObject\Source\RectorWithLink" ("https://github.com/rectorphp/rector/blob/master/docs/rector_rules_overview.md")',
             $rectorWithFileAndLineChange->getRectorClassWithChangelogUrl()
         );
     }

diff --git a/phpstan.neon b/phpstan.neon
@@ -572,3 +572,12 @@ parameters:
 
         # known types
         - '#Parameter (.*?) expects PhpParser\\Node, PhpParser\\Node\|null given#'
+
+        -
+            message: '#Instead of "ReflectionClass" class/interface use "PHPStan\\Reflection\\ClassReflection"#'
+            paths:
+                - packages/ChangesReporting/ValueObject/RectorWithFileAndLineChange.php
+        -
+            message: '#"%s" in sprintf\(\) format must be quoted#'
+            paths:
+                - packages/ChangesReporting/ValueObject/RectorWithFileAndLineChange.php
diff --git a/src/ValueObject/Reporting/FileDiff.php b/src/ValueObject/Reporting/FileDiff.php
@@ -80,9 +80,9 @@ public function getRectorClasses(bool $outputChangelogUrl): array
         $rectorClasses = [];
         foreach ($this->rectorWithFileAndLineChanges as $rectorWithFileAndLineChange) {
             if ($outputChangelogUrl) {
-                $rectorClasses[] = $rectorWithFileAndLineChange->getRectorClass();
-            } else {
                 $rectorClasses[] = $rectorWithFileAndLineChange->getRectorClassWithChangelogUrl();
+            } else {
+                $rectorClasses[] = $rectorWithFileAndLineChange->getRectorClass();
             }
         }