Symfony Route annotations are broken by Rector DEAD_CODE

[dameert]

Bug Report

Subject	Details
Rector version	Rector dev-master@4764fd1
Installed as	composer dependency

Rector "DEAD_CODE" changes Symfony Route annotations defaults incorrectly. defaults={"_format": "json"} becomes defaults={"_format"="json"}.

Minimal PHP Code Causing Issue

<?php
namespace App;

use Symfony\Component\Routing\Annotation\Route;

class Controller
{
    /**
     * @Route("/route/{view}.{_format}", name="views.test", defaults={"_format": "json"}, methods={"POST"})
     */
    public function updateAction()
    {
        return 'oops';
    }
}

https://getrector.org/demo/8d9faf4a-1729-4c34-8d56-6adf9cc63eaf#result

Expected Behaviour

Rector DEAD_CODE should not change the : (including space) to = in Route annotations.

[dameert]

Might be related to #3932 however the change made is different. I am eager to find a solution, but am not sure where to start looking for these annotation updates using the DEAD_CODE set.

[TomasVotruba]

Hi,

this is well known problem. The PHP code (without docblocks) has php-parser, that is handling its format to its best. There is issue there, that was only solved in version 3

The annotation don't have such a tool. Making such a tool requires to hugely modify phpstan/php-doc-parser, which might take months of work. This will be solved in PHP 8 with attributes, but we're not there yet. Saying that, there are made few assumptions to make php doc changes work.

What real issue this causes aparat different syntax?

[TomasVotruba]

Sub-problem of #4334