Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodingStyle] UnderscoreToCamelCaseVariableAndPropertyNameRector #3415

Merged
merged 2 commits into from
May 25, 2020
Merged

[CodingStyle] UnderscoreToCamelCaseVariableAndPropertyNameRector #3415

merged 2 commits into from
May 25, 2020

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented May 24, 2020 •
edited
Loading

Closes #3414

This was referenced May 24, 2020
Closed
Closed
@TomasVotruba TomasVotruba force-pushed the coding-style-under branch 2 times, most recently from 90cb413 to 2184102 Compare May 24, 2020 22:36
@TomasVotruba TomasVotruba merged commit 8c83b60 into master May 25, 2020
@TomasVotruba TomasVotruba deleted the coding-style-under branch May 25, 2020 15:38
@dstepe dstepe mentioned this pull request Oct 12, 2020
Closed
@popovserhii
Copy link

@TomasVotruba As I understand the UnderscoreToCamelCaseVariableAndPropertyNameRector property is not available any more in the latest release? What should we use instead?

@TomasVotruba
Copy link
Member Author

Yes, that's correct. These rules are more about subjective naming conventions, that should be handled by coding standards.
See references coding standard rules #3414

@popovserhii
Copy link

This rule was only the reason why I've started to use Rector and was waiting for 4 months while two related issues will be fixed ( #4620, #5392), and now I need to discover another solution.

@TomasVotruba
Copy link
Member Author

That was my mistake, that original upgrade/refactoring shifted way too close to coding standards. I'm sorry about that.

The phpdoc fix is still in progress, see #4334

@josep11
Copy link

josep11 commented Feb 14, 2023

Hello. It's not on main, right?

@samsonasik
Copy link
Member

@josep11 yes, it removed, if you need it, you can check on CodeIgniter4 custom rule for it with customize on based on CodeIgniter4 coding standard, see https://github.com/codeigniter4/CodeIgniter4/blob/develop/utils/Rector/UnderscoreToCamelCaseVariableNameRector.php

TomasVotruba added a commit that referenced this pull request Feb 25, 2023
@TomasVotruba
Updated Rector to commit ad4d11bdd28af115f8b6dd071c82666dcc3d8daa
2822d14 
rectorphp/rector-src@ad4d11b Fixing random stop rules-tests with paratest (#3415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CodingStyle] under_score to camelCase variable names
4 participants
@TomasVotruba @popovserhii @josep11 @samsonasik