[CodeQuality] Add DateTimeToDateTimeInterfaceRector #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
reviewed
Dec 5, 2020
rules/code-quality/src/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
TomasVotruba
reviewed
Dec 5, 2020
| */ | ||
| final class DateTimeToDateTimeInterfaceRector extends AbstractRector | ||
| { | ||
| private const METHODS_MAP = [ |
There was a problem hiding this comment.
What kind of map is this? Excluded, included or ...?
More specific naming could help
There was a problem hiding this comment.
I've renamed it to METHODS_RETURNING_CLASS_INSTANCE_MAP.
TomasVotruba
reviewed
Dec 5, 2020
rules/code-quality/src/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php
Show resolved
Hide resolved
TomasVotruba
reviewed
Dec 5, 2020
TomasVotruba
reviewed
Dec 5, 2020
TomasVotruba
changed the title
|
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Aug 14, 2023
rectorphp/rector-src@685fe90 Make SimplifyUselessVariableRector run without scope (#4791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4478