Refactor file processors towards universal collector

[TomasVotruba]

Follow up to https://github.com/rectorphp/rector/pull/6060/files

[lulco]

@TomasVotruba Hi, I merged it into my branch with neon files. Content stops changing :) in my processor it is changed and I update content at the end of processing using $file->changeFileContent($newContent).

I got this diff:

6) app/config.neon

    ---------- begin diff ----------
--- Original
+++ New
    ----------- end diff -----------

So something is wrong :)

[TomasVotruba]

This should be called in the end of process() method:

$this->fileDiffFileDecorator->decorate([$file]);

It decorates the file with its diff.

[lulco]

In all processors? I didn’t see that in existing processors. I found it in ApplicationFileProcessor::run. It should be enough, right?

[TomasVotruba]

Not sure. I'll try to debug...

[lulco]

I can prepare some failing small application later tonight if you will need

[TomasVotruba]

So there must be a printer, because every processor has its own - PHP has php-parser printer, JSON has json printer etc.

The best inspiration would be in the smaller one ComposerFileProcessor:

rector/rules/Composer/Application/FileProcessor/ComposerFileProcessor.php

Lines 89 to 90 in 4d4fb36

	$changeFileContent = $this->composerJsonPrinter->printToString($composerJson);
	$file->changeFileContent($changeFileContent);

UPDATED

[TomasVotruba]

can prepare some failing small application later tonight if you will need

Failing CI is always the best 👍

[lulco]

The best inspiration would be in the smaller one ComposerFileProcessor:

OK I don't get it :) printer just creates new content as a string, then method changeFileContent is called and that's all...

How is it possible that it works with composer, but not with NonPhpFileProcessor and NetteDINeonMethodCallRenamer too?

[lulco]

can prepare some failing small application later tonight if you will need

Failing CI is always the best 👍

I'm sure it is :) but this is a test for whole application, because all parts are working standalone, but not together :)