Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic tokens for records and constructors #2146

Merged

Conversation

0dinD
Copy link
Contributor

@0dinD 0dinD commented Oct 3, 2021

Should be merged after eclipse-jdtls/eclipse.jdt.ls#1897

This PR adds scope mapping and superTypes for the new tokens and modifiers introduced in eclipse-jdtls/eclipse.jdt.ls#1897, so that themes aren't required to adopt the new tokens. The superType of annotationMember was also changed from function to method, which was missed after eclipse-jdtls/eclipse.jdt.ls#1608.

Fixes #2124
Fixes #2125

Signed-off-by: 0dinD <zerodind@gmail.com>
Copy link
Contributor

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbricon fbricon merged commit a312fc7 into redhat-developer:master Oct 12, 2021
@fbricon
Copy link
Collaborator

fbricon commented Oct 12, 2021

Thanks @0dinD!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semantic token types for Records Support highlight for constructor call
3 participants