Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to cleanup multus related options #258

Open
s1061123 opened this issue Sep 5, 2018 · 2 comments
Open

need to cleanup multus related options #258

s1061123 opened this issue Sep 5, 2018 · 2 comments

Comments

@s1061123
Copy link
Contributor

s1061123 commented Sep 5, 2018

multus_use_crd, multus_npwg_demo and other multus related options can be cleaned up...

@s1061123
Copy link
Contributor Author

s1061123 commented Sep 5, 2018

idea: add "logFile" and "loglevel" in multus.yml....

@dougbtv
Copy link
Member

dougbtv commented Sep 6, 2018 via email

s1061123 added a commit to s1061123/kube-ansible that referenced this issue Dec 27, 2018
To address redhat-nfvpe#245 and redhat-nfvpe#258, this change fixes followings:
 + rename multus_npwg_demo to multus-2nics
 + make multus_use_crd default
 + add multus_build flag
   (if no/false, use daemonset yaml in github/multus)
 + unsupport legacy multus version
 + add docker_install_suppress_newgrp for latest ansible
 + fix daemonset yaml to support latest k8s
 + fix several build script (e.g. sr-iov cni)

Verified it under following combinations:
 + pod_network_type=none
 + pod_network_type=multus
 + pod_network_type=multus + multus_build=true
 + pod_network_type=none + multus_build=true
 + pod_network_type=multus-2nics
 + pod_network_type=multus-2nics + multus_build=true
s1061123 added a commit to s1061123/kube-ansible that referenced this issue Dec 27, 2018
To address redhat-nfvpe#245 and redhat-nfvpe#258, this change fixes followings:
 + rename multus_npwg_demo to multus-2nics
 + make multus_use_crd default
 + add multus_build flag
   (if no/false, use daemonset yaml in github/multus)
 + unsupport legacy multus version
 + add docker_install_suppress_newgrp for latest ansible
 + fix daemonset yaml to support latest k8s
 + fix several build script (e.g. sr-iov cni)

Verified it under following combinations:
 + pod_network_type=none
 + pod_network_type=multus
 + pod_network_type=multus + multus_build=true
 + pod_network_type=none + multus_build=true
 + pod_network_type=multus-2nics
 + pod_network_type=multus-2nics + multus_build=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants