Support client side caching with RedisCluster #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3102 +/- ##
==========================================
+ Coverage 91.45% 91.58% +0.13%
==========================================
Files 128 128
Lines 33105 33162 +57
==========================================
+ Hits 30275 30372 +97
+ Misses 2830 2790 -40 ☔ View full report in Codecov by Sentry. |
chayim
reviewed
Jan 9, 2024
| await r.flushdb() | ||
| await r.aclose() | ||
| @pytest_asyncio.fixture | ||
| async def r(request, create_redis): |
chayim
reviewed
Jan 9, 2024
|
|
||
| r.flushdb() | ||
| @pytest.fixture() | ||
| def r(request): |
chayim
reviewed
Jan 9, 2024
| @@ -167,6 +167,13 @@ def parse_cluster_myshardid(resp, **options): | |||
| "ssl_password", | |||
| "unix_socket_path", | |||
| "username", | |||
| "cache_enable", | |||
| "client_cache", | |||
| "cache_max_size", | |||
There was a problem hiding this comment.
IMHO I think we have enough duplication with all these. Part of another issue to clean up / tech debt?
chayim
reviewed
Jan 9, 2024
| ) | ||
| return response | ||
| response_from_cache = connection._get_from_local_cache(args) | ||
| if response_from_cache is not None: |
chayim
approved these changes
Jan 9, 2024
vladvildanov
reviewed
Jan 9, 2024
| @@ -227,6 +227,10 @@ def __init__( | |||
| _cache = None | |||
| self.client_cache = client_cache if client_cache is not None else _cache | |||
| if self.client_cache is not None: | |||
| if self.protocol not in [3, "3"]: | |||
| raise RedisError( | |||
| "client caching is only supported with protocol version 3 or higher" | |||
There was a problem hiding this comment.
@chayim As I remember we agreed to force RESP3 instead of raising an error? Error should be thrown after it
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
* sync * fix mock_node_resp * fix mock_node_resp_func * fix test_handling_cluster_failover_to_a_replica * fix test_handling_cluster_failover_to_a_replica * async cluster and cleanup tests * delete comment
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
* sync * fix mock_node_resp * fix mock_node_resp_func * fix test_handling_cluster_failover_to_a_replica * fix test_handling_cluster_failover_to_a_replica * async cluster and cleanup tests * delete comment
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
* sync * fix mock_node_resp * fix mock_node_resp_func * fix test_handling_cluster_failover_to_a_replica * fix test_handling_cluster_failover_to_a_replica * async cluster and cleanup tests * delete comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the client-side-caching support to RedisCluster.