Use standard Redis docker image in CI #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI, at least in theory, against different versions of Redis and Redis Stack dockers.
Run the test cluster based on the default Redis docker image, i.e. without Stack support. This is needed in order to make the CI pass until Stack gets a new release. What is needed is to mark all Stack related tests accordingly, and then they don't get executed in the cluster tests (they are already filtered out in `invoke cluster-tests`). Take the opportunity to remove some empty tests and to fix the naming in two tests.
uglide
reviewed
May 29, 2024
| @@ -2450,6 +2450,7 @@ def try_delete_libs(self, r, *lib_names): | |||
| except Exception: | |||
| pass | |||
|
|
|||
| @pytest.mark.redismod | |||
There was a problem hiding this comment.
You basically skipped those tests with redismod mark, because cluster tests exclude redismod
Line 73 in 0d47d65
It's not critical for these tests because T&F is deprecated anyway, but be careful with it in the future.
There was a problem hiding this comment.
Yes, exactly. This is until we get the next release for Stack, at that time hopefully these can be re-enabled in some form.
vladvildanov
approved these changes
Jun 6, 2024
gerzse
added a commit
to gerzse/redis-py
that referenced
this pull request
Jul 11, 2024
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI against different versions of Redis and Redis Stack. Run the test cluster based on the default Redis docker image, i.e. without Stack support. This is needed in order to make the CI pass until Stack gets a new release. What is needed is to mark all Stack related tests accordingly, and then they don't get executed in the cluster tests (they are already filtered out in `invoke cluster-tests`). Take the opportunity to remove some empty tests and to fix the naming in two tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
gerzse
added a commit
that referenced
this pull request
Jul 11, 2024
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI against different versions of Redis and Redis Stack. Run the test cluster based on the default Redis docker image, i.e. without Stack support. This is needed in order to make the CI pass until Stack gets a new release. What is needed is to mark all Stack related tests accordingly, and then they don't get executed in the cluster tests (they are already filtered out in `invoke cluster-tests`). Take the opportunity to remove some empty tests and to fix the naming in two tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
agnesnatasya
pushed a commit
to agnesnatasya/redis-py
that referenced
this pull request
Jul 20, 2024
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI against different versions of Redis and Redis Stack. Run the test cluster based on the default Redis docker image, i.e. without Stack support. This is needed in order to make the CI pass until Stack gets a new release. What is needed is to mark all Stack related tests accordingly, and then they don't get executed in the cluster tests (they are already filtered out in `invoke cluster-tests`). Take the opportunity to remove some empty tests and to fix the naming in two tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI against different versions of Redis and Redis Stack. Run the test cluster based on the default Redis docker image, i.e. without Stack support. This is needed in order to make the CI pass until Stack gets a new release. What is needed is to mark all Stack related tests accordingly, and then they don't get executed in the cluster tests (they are already filtered out in `invoke cluster-tests`). Take the opportunity to remove some empty tests and to fix the naming in two tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI against different versions of Redis and Redis Stack. Run the test cluster based on the default Redis docker image, i.e. without Stack support. This is needed in order to make the CI pass until Stack gets a new release. What is needed is to mark all Stack related tests accordingly, and then they don't get executed in the cluster tests (they are already filtered out in `invoke cluster-tests`). Take the opportunity to remove some empty tests and to fix the naming in two tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI against different versions of Redis and Redis Stack. Run the test cluster based on the default Redis docker image, i.e. without Stack support. This is needed in order to make the CI pass until Stack gets a new release. What is needed is to mark all Stack related tests accordingly, and then they don't get executed in the cluster tests (they are already filtered out in `invoke cluster-tests`). Take the opportunity to remove some empty tests and to fix the naming in two tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the tests to use the standard Redis docker image where possible, instead of using the Redis Stack image in all places. This way we can run the CI, at least in theory, against different versions of Redis and Redis Stack dockers.