Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: too large arguments #595

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: too large arguments #595

merged 1 commit into from
Jul 30, 2024

Conversation

proost
Copy link
Contributor

@proost proost commented Jul 30, 2024

I got error, when redis.call parameters are too large.

user_script:15: too many results to unpack script: 73a336266d816e4bcf60d6cf47daafcad23ad693, on @user_script:15

LUAI_MAXCSTACK in luaconf.h limits stack slots. script can run very long, but it should be avoided by user not rueidisprob.

@rueian
Copy link
Collaborator

rueian commented Jul 30, 2024

LGTM.

@rueian rueian merged commit bc36ea2 into redis:main Jul 30, 2024
19 checks passed
@rueian
Copy link
Collaborator

rueian commented Jul 30, 2024

BTW, would it be better if we group, for example, 4 bits into one BITFIELD call?

@proost proost deleted the fix-do-not-use-unpack branch July 30, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants