Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that <Prompt> support is missing from v6 #8436

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

petersendidit
Copy link
Contributor

Many code bases use the <Prompt> component from v5 but don't find out that support is currently missing from v6 until after attempting to upgrade. This adds this information to the upgrade guide so that is more likely that I would be discovered before lots of effort is invested.

Fixes #8330

Many code bases use the `<Prompt>` component from v5 but don't find out that support is currently missing from v6 until after attempting to upgrade.  This adds this information to the upgrade guide so that is more likely that I would be discovered before lots of effort is invested. 

Fixes remix-run#8330
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 2, 2021

Hi @petersendidit,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 2, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@petersendidit
Copy link
Contributor Author

Reasoning was directly pulled from #8139 (comment)

@timdorr
Copy link
Member

timdorr commented Dec 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 to v6 upgrade guide should mention that usePrompt and <Prompt> have been removed
2 participants