Filter deprecation logs from integration tests assertions

remix-run · Mar 21, 2023 · b72bc8c · b72bc8c
1 parent ca0edff
commit b72bc8c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/integration/action-test.ts b/integration/action-test.ts
@@ -109,7 +109,10 @@ test.describe("actions", () => {
 
   test.beforeEach(({ page }) => {
     page.on("console", (msg) => {
-      logs.push(msg.text());
+      let text = msg.text();
+      if (!/DEPRECATED.*imagesizes.*imagesrcset/.test(text)) {
+        logs.push(text);
+      }
     });
   });
 

diff --git a/integration/defer-test.ts b/integration/defer-test.ts
@@ -1287,7 +1287,8 @@ function monitorConsole(page: Page) {
         let arg0 = await args[0].jsonValue();
         if (
           typeof arg0 === "string" &&
-          arg0.includes("Download the React DevTools")
+          (arg0.includes("Download the React DevTools") ||
+            /DEPRECATED.*imagesizes.*imagesrcset/.test(arg0))
         ) {
           continue;
         }