chore: stop modifying user tsconfig (#6156)

Signed-off-by: Logan McAnsh <logan@mcan.sh>
remix-run · Apr 27, 2023 · dd0c23f · dd0c23f
1 parent 10b0399
commit dd0c23f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 347 deletions.
diff --git a/.changeset/tsconfig-no-modify.md b/.changeset/tsconfig-no-modify.md
@@ -0,0 +1,6 @@
+---
+"remix": patch
+"@remix-run/dev": patch
+---
+
+stop modifying a user's tsconfig when running using `getConfig` (`remix dev`, `remix routes`, `remix build`, etc)
diff --git a/integration/tsconfig-test.ts b/integration/tsconfig-test.ts
diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts
@@ -10,7 +10,6 @@ import type { RouteManifest, DefineRoutesFunction } from "./config/routes";
 import { defineRoutes } from "./config/routes";
 import { defineConventionalRoutes } from "./config/routesConvention";
 import { ServerMode, isValidServerMode } from "./config/serverModes";
-import { writeConfigDefaults } from "./config/write-tsconfig-defaults";
 import { serverBuildVirtualModule } from "./compiler/server/virtualModules";
 import { flatRoutes } from "./config/flat-routes";
 import { detectPackageManager } from "./cli/detectPackageManager";
@@ -733,10 +732,6 @@ export async function readConfig(
     tsconfigPath = rootJsConfig;
   }
 
-  if (tsconfigPath) {
-    writeConfigDefaults(tsconfigPath);
-  }
-
   let future: FutureConfig = {
     unstable_dev: appConfig.future?.unstable_dev ?? false,
     unstable_postcss: appConfig.future?.unstable_postcss === true,

diff --git a/packages/remix-dev/config/write-tsconfig-defaults.ts b/packages/remix-dev/config/write-tsconfig-defaults.ts