Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/cli): fix heap out of memory error #4294

Closed
wants to merge 1 commit into from

Conversation

arnaudambro
Copy link
Contributor

closing #1555

I'm not sure of the fix though because I don't understand the whole logic there

but the bug was a pain in the *ss before that "fix", and I have no more bug after !

closing remix-run#1555

I'm not sure of the fix though because I don't understand the whole logic there

but the bug was a pain in the *ss before that "fix", and I have no more bug after !
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

⚠️ No Changeset found

Latest commit: fae6e32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title fix(remix-dev/cli): JavaScript heap out of memory fix(remix-dev/cli): fix heap out of memory error Sep 29, 2022
@MichaelDeBoey MichaelDeBoey linked an issue Sep 29, 2022 that may be closed by this pull request
@ZipBrandon
Copy link

@arnaudambro Thank you for your investigation and this PR!

@balzdur
Copy link

balzdur commented Jan 9, 2023

It would be awesome if someone from the core team could look at this 🙏🏽

@pcattori
Copy link
Contributor

pcattori commented Jan 22, 2023

Superceded by #5133 which will make the new dev server available in the next minor release under the unstable_dev future flag.

Note that we needed to rearchitect the dev server as moving the require cache purging to onRebuildFinished in the current dev server caused race conditions

@pcattori pcattori closed this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JavaScript heap out of memory
5 participants