bug: v1.8 loaders have empty request.headers when called after action

[nrako]

This is a bug report: yarn bug-report-test

---

Prior to Remix v1.8.0 the loader function when called subsequentially to a (POST) action would have the request's headers set. Since v1.8 this is not the case anymore.

This is highlyt problematic. For example, if you have some high level session based cookie which is used to guard GET request in the page action (or a parent layout route); the authentication would fail every time the loaders data is retrieved subsequentially to a POST action.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9c063cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[nrako]

By the way, at first I verified things in isolation in that codesandbox if that can be of any use to anyone: https://codesandbox.io/s/hardcore-ben-hwsb4j?file=/app/routes/demos/actions.tsx

Just flip @remix-run/serve between 1.7.6 and 1.8.0 (or later) and don't forgot to restart the server in between your manual tests on the /demos/actions page.

[brophdawg11]

Thanks! Moved this out of the bug report test and added some additional test in #4829. The underlying fix for this is over in react-router: remix-run/react-router#9721

[brophdawg11]

Hey @nrako - just FYI this fix is available in a 1.9.0-pre.0 release if you wanted to give it a test! We're hoping to get the stable 1.9.0 out later today or tomorrow.

[nrako]

Thanks for letting me know @brophdawg11, I did a quick test with @remix-run/server-runtime and that looks great, my tests are all green. thx for Remix's team great work!