RRR Rendering #4900
Merged
RRR Rendering #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mehdi Achour <machour@gmail.com>
* First pass at SSR using react-router-dom@6.4 * useLoaderData/useActionData generics + useTransition/useFetcher types * Remove duped router in favor of 1.0.4-pre.0
Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
🦋 Changeset detectedLatest commit: fc5b75e The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* Fix flakey firefox tests * Fix flakey upload tests * Add integration tests for useLoaderData/ErrorBoundary
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
This was referenced Dec 20, 2022
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires up Remix to use the new data APIs from React Router 6.4+ and removes all of the code that we originally wrote in Remix for those APIs 🎉 . This encompasses steps 2-4 of React Router-ing Remix.
With this PR Remix is now:
createStaticHandlercreateStaticRouter/<StaticRouteProvider>createBrowserRouter/<RouterProvider>This also means Remix inherits:
useNavigationuseRevalidatorshouldRevalidate(and removal ofunstable_shouldReload)getKeyprop on<ScrollRestoration>preventScrollResetprop on<Link>This has been a ton of work so I expect we'll uncover some bugs, but we're at a point now that we're functionally done as far as we know 😉. But since we don't know what we don't know, please raise concerns with any issues, typing deltas, etc.
Related info: