Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSS side effect imports #4919

Merged
merged 115 commits into from
Jan 4, 2023
Merged

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Dec 20, 2022

Closes: #4817

  • Docs
  • Tests

Testing Strategy:

There is an integration test covering the build pipeline to ensure that all relevant styles end up on the page.

There's also a suite of unit tests to validate that CSS side effect imports are detected and annotated correctly for different usages of require/import.

I also trialled this in a playground using both uikit-test-using-css and React Spectrum that were referenced in the original issue: #2469

Base automatically changed from markdalgleish/css-modules to dev January 4, 2023 00:10
@markdalgleish markdalgleish marked this pull request as ready for review January 4, 2023 00:31
@markdalgleish markdalgleish merged commit 26f33ee into dev Jan 4, 2023
@markdalgleish markdalgleish deleted the markdalgleish/css-side-effects branch January 4, 2023 02:17
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-2c398e4-20230104 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants