Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-react): add types to useRouteLoaderData #5157

Merged
merged 2 commits into from
Jul 5, 2023
Merged

feat(remix-react): add types to useRouteLoaderData #5157

merged 2 commits into from
Jul 5, 2023

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Jan 20, 2023 •
edited
Loading

Closes: #

  • Docs
  • Tests

Testing Strategy: added unit tests

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9b9e218

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lpsinger
Copy link
Contributor Author

I didn't add any documentation for this because I could not find the file for https://remix.run/docs/en/v1/hooks/use-route-loader-data on the dev branch.

machour
machour previously requested changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lpsinger and thank you for your contribution!

This change needs to target the dev branch. Also make sure you don't include other commits than yours in the PR

@lpsinger lpsinger changed the base branch from main to dev January 20, 2023 07:19
@lpsinger
Copy link
Contributor Author

This change needs to target the dev branch. Also make sure you don't include other commits than yours in the PR

Fixed.

@machour machour changed the title Use route loader data template feat(remix-react): add typing to useRouteLoaderData Jan 20, 2023
@WesleyYue

This comment was marked as off-topic.

Sign in to view
@lpsinger

This comment was marked as off-topic.

Sign in to view
@lpsinger lpsinger force-pushed the use-route-loader-data-template branch from cabc9f3 to 17ad262 Compare March 8, 2023 18:30
@MichaelDeBoey MichaelDeBoey force-pushed the use-route-loader-data-template branch from 17ad262 to 10f99a0 Compare March 9, 2023 00:59
@KevinMind

This comment was marked as off-topic.

Sign in to view
@lpsinger

This comment was marked as off-topic.

Sign in to view
@kiliman

This comment was marked as off-topic.

Sign in to view
@lpsinger @MichaelDeBoey
feat(remix-react): add typing to useRouteLoaderData
c061146 
useRouteLoaderData will support typing, just like useLoaderData.
@MichaelDeBoey MichaelDeBoey force-pushed the use-route-loader-data-template branch from 10f99a0 to c061146 Compare May 2, 2023 00:18
@MichaelDeBoey MichaelDeBoey changed the title feat(remix-react): add typing to useRouteLoaderData feat(remix-react): add types to useRouteLoaderData May 2, 2023
@brophdawg11 brophdawg11 requested review from pcattori and jacob-ebey and removed request for brophdawg11 May 2, 2023 13:13
@brophdawg11 brophdawg11 merged commit d743e19 into remix-run:dev Jul 5, 2023
9 checks passed
@lpsinger lpsinger deleted the use-route-loader-data-template branch July 5, 2023 13:40
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-da44482-20230706 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 13, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-sherman tom-sherman tom-sherman left review comments

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@machour machour machour left review comments

@mcansh mcansh Awaiting requested review from mcansh

@pcattori pcattori Awaiting requested review from pcattori

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees

@pcattori pcattori

Labels
CLA Signed feat:typescript renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpsinger @WesleyYue @KevinMind @kiliman @machour @MichaelDeBoey @tom-sherman @pcattori @brophdawg11