feat(remix-dev): add opt-in Vanilla Extract cache #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 53a7a10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
commented
Mar 13, 2023
| @@ -1,219 +1,30 @@ | |||
| import { dirname, join, extname } from "path"; | |||
| import type { IdentifierOption } from "@vanilla-extract/integration"; | |||
There was a problem hiding this comment.
Git didn't track this one very well — the original contents of this file have been moved to vanillaExtractPluginUncached.ts. vanillaExtractPlugin.ts now just switches between the cached and uncached plugins since their implementations are so different.
chaance
approved these changes
Mar 13, 2023
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5524
For now this is opt-in since the cache is powered by a brand new Vanilla Extract compiler that uses vite-node. Since this is a large architectural change, we'll want to ensure it's working correctly in the wild before making it the default. As a result, I've also left this option undocumented until we get some initial feedback.
Testing Strategy:
All tests that exercise the Vanilla Extract integration are now also being run against the new compiler.