Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): Allow meta data and parentsData to be undefined #5787

Closed
wants to merge 2 commits into from

Conversation

kentcdodds
Copy link
Member

Closes: #5786

- [ ] Docs
- [ ] Tests

Testing Strategy:

I tried it locally and it seems to work 👍

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

⚠️ No Changeset found

Latest commit: 838c79a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aaronadamsCA
Copy link
Contributor

IMO this would be well worth a patch release, because so far migrating to meta v2 is quite dangerous without it.

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds could you fix the conflicts in order to get this PR merged?

I also noticed the same problem in packages/remix-react/routeModules.ts, not sure why this definitions are duplicated there, but they'll need fixing too. (I had #6231 open to fix it before noticing your PR)

@kentcdodds
Copy link
Member Author

This is untested. Think of this as more of an issue than a PR.

@brophdawg11
Copy link
Contributor

Closing in favor of #6231

@brophdawg11 brophdawg11 closed this May 5, 2023
@MichaelDeBoey MichaelDeBoey deleted the kentcdodds-patch-2 branch May 6, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants