Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dev): skip Remix/React packages in CSS build #6654

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

markdalgleish
Copy link
Member

The CSS bundle build ultimately only cares CSS imports and these packages are known not to contain any, so this PR allows esbuild to skip compilation of these packages entirely. In my basic example app using CSS bundling, I've seen builds go from ~170ms to ~120ms.

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

🦋 Changeset detected

Latest commit: 817024f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit 286545e into dev Jun 21, 2023
9 checks passed
@pcattori pcattori deleted the markdalgleish/css-bundle-skip-packages branch June 21, 2023 02:17
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jun 21, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-ccefed3-20230621 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@kiliman
Copy link
Collaborator

kiliman commented Jun 21, 2023

Hi. Just curious about the decision to exclude packages instead of creating a whitelist in remix.config. I'd assume we would just include app/* and exclude node_modules/* by default. Then let the developer include specific folders to scan for CSS files.

@pcattori
Copy link
Contributor

@kiliman this was a way of improving perf without changing API. Though I personally agree that we should explore the approach you suggest as well.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants